[Cashtab] Show option to claim token reward from Home page if wallet is new
ClosedPublic
Actions

Authored by bytesofman on Jul 19 2024, 23:02.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC361ae4913865: [Cashtab] Show option to claim token reward from Home page if wallet is new

Summary

A newly-created wallet is always eligible for token rewards.

Add an option to the first screen a user sees when they create a wallet to "Claim Airdrop."

Considered (and implemented in testing) the option of just having the wallet auto-claim an airdrop on creation. However this could be a bit confusing to the user. The "Backup wallet" msg flashes briefly. The airdrop received msg is nice, but it is unclear why or what happened.

Having the user click a button and shortly after receive a tx is imo more satisfying and less ambiguous.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

new-wallet-auto-rewards

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29643
Build 58821: Build Diff	cashtab-tests · ecash-lib-tests
Build 58820: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 19 2024, 23:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2024, 23:02

better comments

Harbormaster completed remote builds in B29643: Diff 48752.Jul 19 2024, 23:05

bytesofman edited the summary of this revision. (Show Details)Jul 19 2024, 23:06

Harbormaster completed remote builds in B29644: Diff 48753.Jul 19 2024, 23:08

bytesofman published this revision for review.Jul 19 2024, 23:11

Accepted with minor nit

cashtab/src/components/Home/Home.js
208 ↗	(On Diff #48753)	I think most people would assume `Claim Airdrop` to mean an XEC airdrop. If we ever offer XEC airdrops users might ignore it thinking it's just another eToken.

This revision is now accepted and ready to land.Jul 20 2024, 15:09

bytesofman added inline comments.Jul 20 2024, 23:03

cashtab/src/components/Home/Home.js
208 ↗	(On Diff #48753)	True. However, this diff is also prep for starting to promote Cashtab and wallet creation from the e.cash landing page. I don't think a totally new user will know what CACHET is. Also confusing that, after the airdrop, the user has no XEC. imo something that should be fixed server side, mb by adding a new-wallet airdrop that is only XEC, or XEC + CACHET so the user can send or burn tokens or the same with XEC 🤔 For now..will just live with the ambiguity, as we are going to advertise "airdrop" on the landing page, and I don't want never-used-ecash-before users to then have to process "wait wtf is CACHET". Will work server-side to add XEC to airdrops that specifically are going to wallets with no tx history.