Differential D16538

Improve the ZMQ functional test
ClosedPublic
Actions

Authored by Fabien on Jul 27 2024, 21:05.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC748343d6c5ef: Improve the ZMQ functional test

Summary

While reading the code in this test I found the reorg case very confusing, and some code seems misplaced. This diff moves the code where appropriated, and add the validation interface callbacks in the comments so that it can be understood.

Test Plan

./test/functional/test_runner.py interface_zmq.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 27 2024, 21:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2024, 21:05

Fabien requested review of this revision.Jul 27 2024, 21:05

Harbormaster completed remote builds in B29736: Diff 48865.Jul 27 2024, 21:25

Fabien added a child revision: D16539: Get rid of ConnectTrace.Jul 27 2024, 21:32

PiRK accepted this revision.Jul 29 2024, 07:13

This revision is now accepted and ready to land.Jul 29 2024, 07:13

Closed by commit rABC748343d6c5ef: Improve the ZMQ functional test (authored by Fabien). · Explain WhyJul 29 2024, 07:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC748343d6c5ef: Improve the ZMQ functional test.

Revision Contents
Changeset List

Path

Size

test/

functional/

interface_zmq.py

16 lines

Diff 48872

View Options

test/functional/interface_zmq.py

Improve the ZMQ functional testClosedPublicActions