Page MenuHomePhabricator
Differential D16600

[ecash-herald] consistently apply en-US locale for locale formatted strings
ClosedPublic
Actions

Authored by bytesofman on Aug 7 2024, 15:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC31225d61eaac: [ecash-herald] consistently apply en-US locale for locale formatted strings
Summary

Can get mock generation inconsistencies if user without en-US locale settings generates mocks. Specify en-US everywhere.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Aug 7 2024, 15:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2024, 15:36
Harbormaster completed remote builds in B29889: Diff 49077.Aug 7 2024, 15:37
Fabien added a subscriber: Fabien.Aug 7 2024, 15:42

you're missing one in events.test.js:276

bytesofman updated this revision to Diff 49078.Aug 7 2024, 15:51

add events.test.js locale specification

bytesofman published this revision for review.Aug 7 2024, 15:51
Fabien accepted this revision.Aug 7 2024, 15:51
This revision is now accepted and ready to land.Aug 7 2024, 15:51
This revision was landed with ongoing or failed builds.Aug 7 2024, 15:52
Closed by commit rABC31225d61eaac: [ecash-herald] consistently apply en-US locale for locale formatted strings (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC31225d61eaac: [ecash-herald] consistently apply en-US locale for locale formatted strings.
Harbormaster completed remote builds in B29890: Diff 49078.Aug 7 2024, 15:53

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
4 lines
2 lines
6 lines
test/
4 lines

Diff 49079

View Options

apps/ecash-herald/src/events.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/src/utils.js

Loading...
View Options

apps/ecash-herald/test/events.test.js

Loading...