Page MenuHomePhabricator

[ecash-herald] consistently apply en-US locale for locale formatted strings
ClosedPublic

Authored by bytesofman on Aug 7 2024, 15:35.

Details

Summary

Can get mock generation inconsistencies if user without en-US locale settings generates mocks. Specify en-US everywhere.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
locale-herald
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29889
Build 59313: Build Diffecash-herald-tests
Build 59312: arc lint + arc unit

Event Timeline

you're missing one in events.test.js:276

add events.test.js locale specification

bytesofman published this revision for review.Aug 7 2024, 15:51
This revision is now accepted and ready to land.Aug 7 2024, 15:51
This revision was landed with ongoing or failed builds.Aug 7 2024, 15:52
This revision was automatically updated to reflect the committed changes.