Differential D16638

Let mapNextTx store shared pointers instead of raw pointers
ClosedPublic
Actions

Authored by Fabien on Aug 13 2024, 14:41.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC65ca02e1ecf9: Let mapNextTx store shared pointers instead of raw pointers

Summary

This is safer and will make it possible to copy and move the content of the map.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

next_tx_ref

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29965
Build 59464: Build Diff	build-diff · build-without-wallet · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug
Build 59463: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 13 2024, 14:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2024, 14:41

Fabien requested review of this revision.Aug 13 2024, 14:41

Harbormaster completed remote builds in B29965: Diff 49179.Aug 13 2024, 15:03

roqqit accepted this revision.Aug 13 2024, 19:03

This revision is now accepted and ready to land.Aug 13 2024, 19:03

Closed by commit rABC65ca02e1ecf9: Let mapNextTx store shared pointers instead of raw pointers (authored by Fabien). · Explain WhyAug 13 2024, 19:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC65ca02e1ecf9: Let mapNextTx store shared pointers instead of raw pointers.

Revision Contents
Changeset List

Path

Size

src/

policy/

block/

preconsensus.cpp

2 lines

test/

blockencodings_tests.cpp

40 lines

txmempool.h

4 lines

txmempool.cpp

12 lines

validation.cpp

3 lines

Diff 49179

View Options

src/policy/block/preconsensus.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

Let mapNextTx store shared pointers instead of raw pointersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49179

src/policy/block/preconsensus.cpp

src/test/blockencodings_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/validation.cpp

Let mapNextTx store shared pointers instead of raw pointers
ClosedPublic
Actions

Revision Contents
Changeset List