Differential D16639

[e.cash] Prevent social icons in nav from flashing
ClosedPublic
Actions

Authored by johnkuney on Aug 13 2024, 17:06.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0930ef80fff6: [e.cash] Prevent social icons in nav from flashing

Summary

Social icons are flashing for a sec on load on desktop. Adding some CSS to avoid

Test Plan

preview the site and check you dont see the icons

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-menuicons

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29967
Build 59468: Build Diff
Build 59467: arc lint + arc unit

Event Timeline

johnkuney created this revision.Aug 13 2024, 17:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2024, 17:06

johnkuney requested review of this revision.Aug 13 2024, 17:06

Harbormaster completed remote builds in B29967: Diff 49185.Aug 13 2024, 17:06

@bot preview-e.cash

teamcity awarded a token.Aug 13 2024, 17:16

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.63:41644 for the next 60 minutes.

bytesofman accepted this revision.Aug 13 2024, 17:49

This revision is now accepted and ready to land.Aug 13 2024, 17:49

Closed by commit rABC0930ef80fff6: [e.cash] Prevent social icons in nav from flashing (authored by johnkuney). · Explain WhyAug 13 2024, 17:52

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC0930ef80fff6: [e.cash] Prevent social icons in nav from flashing.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

navbar/

styles.js

5 lines

Diff 49185

View Options

web/e.cash/components/navbar/styles.js

[e.cash] Prevent social icons in nav from flashingClosedPublicActions