Paths

Table of Contentst

Differential D16719

[electrum] misc fixes for OSX build
ClosedPublic
Actions

Authored by PiRK on Sep 5 2024, 13:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC98e4dec4c3b6: [electrum] misc fixes for OSX build

Summary

This fixes a couple of non-fatal errors when running the make_osx script:

pyinstaller 6.4.0 requires pyinstaller-hooks-contrib>=2024.0
readlink: illegal option -- f

The make_osx script already uses greadlink -f, so we can assume that it will be available for the base.sh script as well.

Depends on D16718

Test Plan

contrib/osx/make_osx

Look at the entire log for errors.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 5 2024, 13:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2024, 13:12

PiRK requested review of this revision.Sep 5 2024, 13:12

Harbormaster completed remote builds in B30190: Diff 49500.Sep 5 2024, 13:15

PiRK added a child revision: D16721: [electrum] bump version to 5.3.0, add release notes.Sep 5 2024, 14:22

Fabien accepted this revision.Sep 5 2024, 15:01

This revision is now accepted and ready to land.Sep 5 2024, 15:01

Closed by commit rABC98e4dec4c3b6: [electrum] misc fixes for OSX build (authored by PiRK). · Explain WhySep 5 2024, 18:14

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC98e4dec4c3b6: [electrum] misc fixes for OSX build.

PiRK mentioned this in D16725: [electrum] pinpoint packaging lib and specify hashes for MacOS build.Sep 6 2024, 07:02

PiRK mentioned this in rABC91433c549c89: [electrum] pinpoint packaging lib and specify hashes for MacOS build.Sep 6 2024, 08:19

Revision Contents
Changeset List

Path

Size

electrum/

contrib/

base.sh

7 lines

osx/

requirements-osx-build.txt

6 lines

Diff 49518

View Options

electrum/contrib/base.sh