Differential D1672

Remove the Amount::GetSatoshi function
ClosedPublic
Actions

Authored by deadalnix on Aug 24 2018, 12:59.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING3e39da5a5e39: Remove the Amount::GetSatoshi function
rABC3e39da5a5e39: Remove the Amount::GetSatoshi function

Summary

Also always include ostream as the class is using std::ostream . The iostream on OSX over includes and not including it on other plateform rely on transitive inclusion, which is not desirable.

Depends on D1669, D1670 and D1671

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

satoshi

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3115
Build 4317: Bitcoin ABC Buildbot (legacy)
Build 4316: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 24 2018, 12:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2018, 12:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3115: Diff 4635.Aug 24 2018, 13:36

schancel accepted this revision.Aug 24 2018, 18:55

This revision is now accepted and ready to land.Aug 24 2018, 18:55

Closed by commit rABC3e39da5a5e39: Remove the Amount::GetSatoshi function (authored by deadalnix). · Explain WhyAug 24 2018, 20:13

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

amount.h

8 lines

Diff 4635

View Options

Remove the Amount::GetSatoshi functionClosedPublicActions