Page MenuHomePhabricator

[Iguana] Move ConditionStack to conditionstack.h
ClosedPublic

Authored by tobias_ruck on Sep 16 2024, 09:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe211db9ab22e: [Iguana] Move ConditionStack to conditionstack.h
Summary

To build ScriptInterpreter, we need to have access to ConditionStack in interpreter.h.

The simplest way is moving this into its own header file. The class is so simple that it doesn't need a corresponding cpp file.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
iguana-refactor-condition-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30296
Build 60119: Build Diffbuild-without-wallet · lint-circular-dependencies · build-clang · build-clang-tidy · build-debug · build-diff
Build 60118: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Sep 16 2024, 12:08
Fabien added inline comments.
src/script/conditionstack.h
8 ↗(On Diff #49642)

Also needs <limits> and <cassert>

This revision now requires changes to proceed.Sep 16 2024, 12:08
This revision is now accepted and ready to land.Sep 16 2024, 12:29