Page MenuHomePhabricator
Differential D16770

[Cashtab] NFT token loading syntax patch
ClosedPublic
Actions

Authored by bytesofman on Sep 17 2024, 15:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0da4db982cf9: [Cashtab] NFT token loading syntax patch
Summary

The syntax currently used here ends up defining 2 out of 3 as undefined. This "works" in that you still see 1 loader.

Fix it so all items requiring cache are shown as a loader.

Test Plan

npm test

image.png (546×480 px, 133 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
inline-loader-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30321
Build 60169: Build Diffecash-lib-tests · cashtab-tests
Build 60168: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 17 2024, 15:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2024, 15:23
bytesofman published this revision for review.Sep 17 2024, 15:23
bytesofman edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B30321: Diff 49677.Sep 17 2024, 15:34
Fabien accepted this revision.Sep 17 2024, 19:16
Fabien added a subscriber: Fabien.

TIL

This revision is now accepted and ready to land.Sep 17 2024, 19:16
Closed by commit rABC0da4db982cf9: [Cashtab] NFT token loading syntax patch (authored by bytesofman). · Explain WhySep 17 2024, 21:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC0da4db982cf9: [Cashtab] NFT token loading syntax patch.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Nfts/
28 lines

Diff 49677

View Options

cashtab/src/components/Nfts/index.js

Loading...