Page MenuHomePhabricator

[avalanche] Fix a lock-order issue when adding a tx to the poll
ClosedPublic

Authored by Fabien on Wed, Sep 18, 09:12.

Details

Summary

This fixes a lock order inversion cs_main => voteRecords => cs_main.
We can't call addToReconcile with cs_main hold.

Unfortunately annotating for !cs_main everywhere is not really practicable as it would propagate to all callsites recursively.

Test Plan
./contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable