[avalanche] Add missing const to getWinners
ClosedPublic
Actions

Authored by roqqit on Sep 18 2024, 16:06.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCa18387188c0d: [avalanche] Add missing const to getWinners

Summary

getWinners should never modify the cache

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-missing-const

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30344
Build 60213: Build Diff	lint-circular-dependencies · build-clang-tidy · build-debug · build-clang · build-diff · build-without-wallet
Build 60212: arc lint + arc unit

Event Timeline

roqqit created this revision.Sep 18 2024, 16:06

Owners added a reviewer: Restricted Owners Package.Sep 18 2024, 16:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 18 2024, 16:06

roqqit requested review of this revision.Sep 18 2024, 16:06

Harbormaster completed remote builds in B30344: Diff 49713.Sep 18 2024, 16:25

Fabien accepted this revision.Sep 18 2024, 18:54

This revision is now accepted and ready to land.Sep 18 2024, 18:54

Closed by commit rABCa18387188c0d: [avalanche] Add missing const to getWinners (authored by roqqit). · Explain WhySep 18 2024, 21:33

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCa18387188c0d: [avalanche] Add missing const to getWinners.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

stakecontendercache.h

2 lines

stakecontendercache.cpp

2 lines

Diff 49713

View Options

src/avalanche/stakecontendercache.h