Differential D16801

Lock cs_main when calling the block finalized validation interface
ClosedPublic
Actions

Authored by Fabien on Sep 23 2024, 14:24.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC951e396bc675: Lock cs_main when calling the block finalized validation interface

Summary

For now there is a single subscriber (chronik) so there is no race, but this is a brittle design. Let's take the lock properly to avoid introducing issues in the future.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 23 2024, 14:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2024, 14:24

Fabien requested review of this revision.Sep 23 2024, 14:24

Fabien added a child revision: D16802: [avalanche] Add a block invalidated validation callback.Sep 23 2024, 14:35

Harbormaster completed remote builds in B30386: Diff 49776.Sep 23 2024, 14:47

roqqit accepted this revision.Sep 23 2024, 16:17

This revision is now accepted and ready to land.Sep 23 2024, 16:17

Closed by commit rABC951e396bc675: Lock cs_main when calling the block finalized validation interface (authored by Fabien). · Explain WhySep 24 2024, 14:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC951e396bc675: Lock cs_main when calling the block finalized validation interface.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

2 lines

Diff 49796

View Options

Lock cs_main when calling the block finalized validation interfaceClosedPublicActions