[chronik] Add an avalanche invalidated block ws message
ClosedPublic
Actions

Authored by Fabien on Sep 23 2024, 15:59.

Details

Reviewers

PiRK
tobias_ruck

Group Reviewers

Restricted Project

Commits

rABC1528093c99f8: [chronik] Add an avalanche invalidated block ws message

Summary

This message triggers upon block invalidated by avalanche.

Depends on D16802.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 23 2024, 15:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2024, 15:59

Fabien requested review of this revision.Sep 23 2024, 15:59

Harbormaster completed remote builds in B30388: Diff 49778.Sep 23 2024, 16:26

Diff looks good but my understanding is behind on how chronik "knows" a block has been invalidated by avalanche. Having trouble following the logic in this diff.

Is chronik already handling this case but just not sending a msg? Where is the case recognized?

In D16803#381211, @bytesofman wrote:

Diff looks good but my understanding is behind on how chronik "knows" a block has been invalidated by avalanche. Having trouble following the logic in this diff.

Is chronik already handling this case but just not sending a msg? Where is the case recognized?

It is happening in chronik_validationinterface.cpp on line 67. Chronik registers a "validation interface" , and defines what happens when each callback is triggered.
The "avalanche invalidated" callback has been added in D16802

This revision is now accepted and ready to land.Sep 23 2024, 18:55

Fabien added a child revision: D16805: [chronik] Add more data to the blocks ws message.Sep 24 2024, 09:24