Page MenuHomePhabricator
Differential D16831

Lint everything
ClosedPublic
Actions

Authored by Fabien on Oct 1 2024, 12:29.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCe9f1878f1f4d: Lint everything
Summary

As per title.

Depends on D16830.

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 1 2024, 12:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2024, 12:29
Fabien requested review of this revision.Oct 1 2024, 12:29
Fabien added a child revision: Restricted Differential Revision.Oct 1 2024, 12:33
Harbormaster completed remote builds in B30445: Diff 49865.Oct 1 2024, 12:51
teamcity added a comment.Oct 1 2024, 12:52
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

wallet_startup.py                          | ✓ Passed  | 6 s
wallet_timelock.py                         | ✓ Passed  | 2 s
wallet_txn_clone.py                        | ✓ Passed  | 3 s
wallet_txn_clone.py --mineblock            | ✓ Passed  | 4 s
wallet_txn_doublespend.py                  | ✓ Passed  | 4 s
wallet_txn_doublespend.py --mineblock      | ✓ Passed  | 4 s
wallet_watchonly.py                        | ✓ Passed  | 3 s
wallet_watchonly.py --usecli               | ✓ Passed  | 3 s
chronik_avalanche.py                       | ○ Skipped | 0 s
chronik_block.py                           | ○ Skipped | 0 s
chronik_block_header.py                    | ○ Skipped | 0 s
chronik_block_info.py                      | ○ Skipped | 0 s
chronik_block_txs.py                       | ○ Skipped | 0 s
chronik_blockchain_info.py                 | ○ Skipped | 0 s
chronik_blocks.py                          | ○ Skipped | 0 s
chronik_chronik_info.py                    | ○ Skipped | 0 s
chronik_cors.py                            | ○ Skipped | 0 s
chronik_disable_token_index.py             | ○ Skipped | 0 s
chronik_disallow_prune.py                  | ○ Skipped | 0 s
chronik_lokad_id_group.py                  | ○ Skipped | 0 s
chronik_mempool_conflicts.py               | ○ Skipped | 0 s
chronik_mempool_disconnectpool.py          | ○ Skipped | 0 s
chronik_pause.py                           | ○ Skipped | 0 s
chronik_plugin_groups.py                   | ○ Skipped | 0 s
chronik_plugins.py                         | ○ Skipped | 0 s
chronik_plugins_setup.py                   | ○ Skipped | 0 s
chronik_raw_tx.py                          | ○ Skipped | 0 s
chronik_resync.py                          | ○ Skipped | 0 s
chronik_script_confirmed_txs.py            | ○ Skipped | 0 s
chronik_script_history.py                  | ○ Skipped | 0 s
chronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
chronik_script_utxos.py                    | ○ Skipped | 0 s
chronik_serve.py                           | ○ Skipped | 0 s
chronik_spent_by.py                        | ○ Skipped | 0 s
chronik_token_alp.py                       | ○ Skipped | 0 s
chronik_token_broadcast_txs.py             | ○ Skipped | 0 s
chronik_token_burn.py                      | ○ Skipped | 0 s
chronik_token_id_group.py                  | ○ Skipped | 0 s
chronik_token_parse_failure.py             | ○ Skipped | 0 s
chronik_token_script_group.py              | ○ Skipped | 0 s
chronik_token_slp_fungible.py              | ○ Skipped | 0 s
chronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
chronik_token_slp_nft1.py                  | ○ Skipped | 0 s
chronik_tx.py                              | ○ Skipped | 0 s
chronik_tx_removal_order.py                | ○ Skipped | 0 s
chronik_ws.py                              | ○ Skipped | 0 s
chronik_ws_ordering.py                     | ○ Skipped | 0 s
chronik_ws_ping.py                         | ○ Skipped | 0 s
chronik_ws_script.py                       | ○ Skipped | 0 s
feature_bind_port_discover.py              | ○ Skipped | 0 s
feature_bind_port_externalip.py            | ○ Skipped | 0 s
interface_usdt_net.py                      | ○ Skipped | 0 s
interface_usdt_utxocache.py                | ○ Skipped | 0 s
interface_usdt_validation.py               | ○ Skipped | 0 s

ALL                                        | ✓ Passed  | 2201 s (accumulated) 
Runtime: 440 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK accepted this revision.Oct 1 2024, 14:35
PiRK added a subscriber: PiRK.

Looks good. I don't understand the CI failure, though, please check that it is unrelated.

This revision is now accepted and ready to land.Oct 1 2024, 14:35
Fabien added a comment.Oct 1 2024, 14:49
In D16831#381865, @PiRK wrote:

Looks good. I don't understand the CI failure, though, please check that it is unrelated.

I did, not sure what happened either but it's unrelated.

Closed by commit rABCe9f1878f1f4d: Lint everything (authored by Fabien). · Explain WhyOct 1 2024, 14:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe9f1878f1f4d: Lint everything.

Revision Contents
Changeset List

PathSize
contrib/
buildbot/
2 lines
devtools/
4 lines
seeds/
2 lines
electrum/
electrumabc/
2 lines
2 lines
electrumabc_gui/
qt/
2 lines
2 lines
electrumabc_plugins/
fusion/
4 lines
satochip/
12 lines
modules/
ecash-lib/
src/
4 lines
test/
functional/
4 lines
web/
e.cash/
styles/
pages/
3 lines

Diff 49870

View Options

contrib/buildbot/server.py

Loading...
View Options

contrib/devtools/copyright_header.py

Loading...
View Options

contrib/seeds/makeseeds.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc/wallet.py

Loading...
View Options

electrum/electrumabc_gui/qt/installwizard.py

Loading...
View Options

electrum/electrumabc_gui/qt/transaction_dialog.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/covert.py

Loading...
View Options

electrum/electrumabc_plugins/satochip/qt.py

Loading...
View Options

modules/ecash-lib/src/sigHashType.ts

Loading...
View Options

test/functional/p2p_addr_relay.py

Loading...
View Options

web/e.cash/styles/pages/use-ecash.js

Loading...