[Iguana] Refactor interpreter and formatter
ClosedPublic
Actions

Authored by tobias_ruck on Thu, Oct 3, 10:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC18bfb880febc: [Iguana] Refactor interpreter and formatter

Summary

Currently, the iguana interpreter captures for each opcode how the stack was before execution of the opcode.

This is fine for the human readable format, but for the CSV format, it is not what is used in practice. There, you need the stack *after* the execution of the opcode.

For this, we first refactor the interpreter and human-readable formatter, which now produces almost the same output (except in the case of an invalidly encoded opcode).

In a later diff, we can add the CSV format.

Test Plan

ninja check-iguana

Diff Detail

Repository

rABC Bitcoin ABC

Branch

iguana-refactor-interpreter

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30486
Build 60489: Build Diff	lint-circular-dependencies · build-debug · build-clang-tidy · build-clang · build-without-wallet · build-diff
Build 60488: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Thu, Oct 3, 10:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Oct 3, 10:51

Harbormaster completed remote builds in B30483: Diff 49926.Thu, Oct 3, 11:16

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_startup.py                          | ✓ Passed  | 6 s
[0m[0;32mwallet_timelock.py                         | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                        | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_clone.py --mineblock            | ✓ Passed  | 6 s
[0m[0;32mwallet_txn_doublespend.py                  | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py --mineblock      | ✓ Passed  | 5 s
[0m[0;32mwallet_watchonly.py                        | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py --usecli               | ✓ Passed  | 3 s
[0m[1;30mchronik_avalanche.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_block.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_block_header.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_block_info.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_block_txs.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_blockchain_info.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_blocks.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_chronik_info.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_cors.py                            | ○ Skipped | 0 s
[0m[1;30mchronik_disable_token_index.py             | ○ Skipped | 0 s
[0m[1;30mchronik_disallow_prune.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_lokad_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_conflicts.py               | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_disconnectpool.py          | ○ Skipped | 0 s
[0m[1;30mchronik_pause.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_plugin_groups.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_plugins.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_plugins_setup.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_raw_tx.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_resync.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_script_confirmed_txs.py            | ○ Skipped | 0 s
[0m[1;30mchronik_script_history.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
[0m[1;30mchronik_script_utxos.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_serve.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_spent_by.py                        | ○ Skipped | 0 s
[0m[1;30mchronik_token_alp.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_token_broadcast_txs.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_burn.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_token_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_token_parse_failure.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_script_group.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_fungible.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_nft1.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_tx.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_tx_removal_order.py                | ○ Skipped | 0 s
[0m[1;30mchronik_ws.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ordering.py                     | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ping.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_ws_script.py                       | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_discover.py              | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_externalip.py            | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                      | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py                | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py               | ○ Skipped | 0 s
[0m[1m
ALL                                        | ✓ Passed  | 2317 s (accumulated) 
[0mRuntime: 470 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

tobias_ruck added a child revision: D16852: [Iguana] Add `-format=csv` to iguana.Thu, Oct 3, 11:44

rerun CI

Harbormaster completed remote builds in B30486: Diff 49931.Thu, Oct 3, 12:44

tobias_ruck published this revision for review.Thu, Oct 3, 13:59

rebase onto master

Harbormaster completed remote builds in B30488: Diff 49933.Thu, Oct 3, 14:23

Fabien accepted this revision.Thu, Oct 3, 15:27

This revision is now accepted and ready to land.Thu, Oct 3, 15:27

Closed by commit rABC18bfb880febc: [Iguana] Refactor interpreter and formatter (authored by tobias_ruck). · Explain WhyFri, Oct 11, 08:12

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC18bfb880febc: [Iguana] Refactor interpreter and formatter.