Page MenuHomePhabricator
Differential D1685

Use TxId in AbandonTransaction
ClosedPublic
Actions

Authored by deadalnix on Aug 25 2018, 20:01.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING2f34bd3b44bb: Use TxId in AbandonTransaction
rABC2f34bd3b44bb: Use TxId in AbandonTransaction
Summary

As per title.

Depends on D1683

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
AbandonTransactionTxId
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3134
Build 4355: Bitcoin ABC Buildbot (legacy)
Build 4354: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 25 2018, 20:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2018, 20:01
teamcity added a subscriber: teamcity.Aug 25 2018, 20:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Aug 25 2018, 20:02
deadalnix added a parent revision: D1683: Use TxId in wallet's GetConflicts methods.
teamcity added a comment.Aug 25 2018, 20:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3134: Diff 4668!Aug 25 2018, 20:12
schancel accepted this revision.Aug 26 2018, 01:30
This revision is now accepted and ready to land.Aug 26 2018, 01:30
deadalnix updated this revision to Diff 4675.Aug 26 2018, 13:17

rebase

teamcity added a comment.Aug 26 2018, 13:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 13:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3140: Diff 4675!Aug 26 2018, 13:29
deadalnix updated this revision to Diff 4681.Aug 26 2018, 14:49

rebase

teamcity added a comment.Aug 26 2018, 14:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 15:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3144: Diff 4681!Aug 26 2018, 15:27
Closed by commit rABC2f34bd3b44bb: Use TxId in AbandonTransaction (authored by deadalnix). · Explain WhyAug 26 2018, 15:44
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
11 lines
2 lines
4 lines
wallet/
2 lines
18 lines

Diff 4668

View Options

src/qt/transactionview.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...