[faucet] Help typescript to infer the type of an empty array
ClosedPublic
Actions

Authored by Fabien on Oct 9 2024, 19:02.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0edc15f825e9: [faucet] Help typescript to infer the type of an empty array

Summary

In the config file the originWhitelist array is documented as possibly empty. This means that typescript has to infer the type from [] which causes a compilation failure.

Test Plan

Empty the array and run npm run build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

faucet_type_infer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30537
Build 60590: Build Diff
Build 60589: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 9 2024, 19:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2024, 19:02

Fabien requested review of this revision.Oct 9 2024, 19:02

Harbormaster completed remote builds in B30537: Diff 50008.Oct 9 2024, 19:02

possibly overkill for this app, but you can see how config.ts defines an interface in token-server to handle this

This revision is now accepted and ready to land.Oct 9 2024, 19:49

Closed by commit rABC0edc15f825e9: [faucet] Help typescript to infer the type of an empty array (authored by Fabien). · Explain WhyOct 10 2024, 06:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0edc15f825e9: [faucet] Help typescript to infer the type of an empty array.

Revision Contents
Changeset List

Path

Size

apps/

faucet/

config.ts

2 lines

Diff 50008

View Options

[faucet] Help typescript to infer the type of an empty arrayClosedPublicActions