Differential D16889

[chronik] Add a test for invalidated blocks on a parked chain
ClosedPublic
Actions

Authored by Fabien on Oct 10 2024, 20:54.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0fb8fe8b3e1e: [chronik] Add a test for invalidated blocks on a parked chain

Summary

When a block connects on a parked chain, it gets invalidated as expected but chronik should not send a websocket message in this case: it's basically another chain at this point.

Test Plan

./test/functional/test_runner.py chronik_ws

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 10 2024, 20:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2024, 20:54

Fabien requested review of this revision.Oct 10 2024, 20:54

Harbormaster completed remote builds in B30556: Diff 50037.Oct 10 2024, 21:25

PiRK accepted this revision.Oct 11 2024, 06:00

PiRK added a subscriber: PiRK.

PiRK added inline comments.

test/functional/chronik_ws.py
222 ↗	(On Diff #50037)	?

This revision is now accepted and ready to land.Oct 11 2024, 06:00

Fabien added inline comments.Oct 11 2024, 07:49

test/functional/chronik_ws.py
222 ↗	(On Diff #50037)	woups, yes it should be invalidate

Closed by commit rABC0fb8fe8b3e1e: [chronik] Add a test for invalidated blocks on a parked chain (authored by Fabien). · Explain WhyOct 11 2024, 07:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0fb8fe8b3e1e: [chronik] Add a test for invalidated blocks on a parked chain.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-lib/

src/

bridge.rs

4 lines

test/

functional/

chronik_ws.py

74 lines

Diff 50048

View Options

chronik/chronik-lib/src/bridge.rs