Page MenuHomePhabricator
Differential D1688

Use TxId in CWallet::MarkConflicted
ClosedPublic
Actions

Authored by deadalnix on Aug 26 2018, 13:28.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING291c4471a0ea: Use TxId in CWallet::MarkConflicted
rABC291c4471a0ea: Use TxId in CWallet::MarkConflicted
Summary

As per title.

Depends on D1683

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
MarkConflictedTxId
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3147
Build 4381: Bitcoin ABC Buildbot (legacy)
Build 4380: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 26 2018, 13:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2018, 13:28
teamcity added a subscriber: teamcity.Aug 26 2018, 13:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 13:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3141: Diff 4676!Aug 26 2018, 13:38
deadalnix updated this revision to Diff 4682.Aug 26 2018, 15:00

rebase

teamcity added a comment.Aug 26 2018, 15:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 15:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3145: Diff 4682!Aug 26 2018, 15:39
deadalnix updated this revision to Diff 4686.Aug 26 2018, 15:48

rebase

teamcity added a comment.Aug 26 2018, 15:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 16:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3147: Diff 4686.Aug 26 2018, 16:27
deadalnix added a child revision: D1695: Use TxId in CWallet::mapTx.Aug 26 2018, 17:35
jasonbcox accepted this revision.Aug 27 2018, 05:54
This revision is now accepted and ready to land.Aug 27 2018, 05:54
deadalnix updated this revision to Diff 4704.Aug 27 2018, 14:14

rebase

teamcity added a comment.Aug 27 2018, 14:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 27 2018, 14:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3161: Diff 4704.Aug 27 2018, 14:55
Closed by commit rABC291c4471a0ea: Use TxId in CWallet::MarkConflicted (authored by deadalnix). · Explain WhySep 2 2018, 15:43
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
8 lines
10 lines

Diff 4686

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...