[seeder] Get rid of pointless `wait` variable and params
ClosedPublic
Actions

Authored by PiRK on Oct 14 2024, 14:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC06b9d443c921: [seeder] Get rid of pointless `wait` variable and params

Summary

As per title

This is a partial backport of bchn#1820
https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/1820/diffs?commit_id=c10b3f01fcf8616c59bf2ddebed9b875f071cd72

Test Plan

ninja & src/seeder/bitcoin-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30584
Build 60684: Build Diff	build-diff · build-debug · build-clang · lint-circular-dependencies · build-without-wallet · build-clang-tidy
Build 60683: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 14 2024, 14:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2024, 14:58

PiRK requested review of this revision.Oct 14 2024, 14:58

teamcity edited the summary of this revision. (Show Details)Oct 14 2024, 14:58

Harbormaster completed remote builds in B30584: Diff 50079.Oct 14 2024, 15:20

PiRK added a child revision: D16905: [seeder] Remove variable that is never read.Oct 14 2024, 15:29

There clearly was an attempt to make the thread sleep longer if there is no processing to do, but the implementation failed. In any case > 5s of delay should be enough to not create any meaningful load on the CPU even with hundreds of crawlers.

This revision is now accepted and ready to land.Oct 14 2024, 19:32

Closed by commit rABC06b9d443c921: [seeder] Get rid of pointless `wait` variable and params (authored by PiRK). · Explain WhyOct 15 2024, 05:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC06b9d443c921: [seeder] Get rid of pointless `wait` variable and params.