Paths

Table of Contentst

Differential D16919

[ecash-agora] syntax replace == with ===
ClosedPublic
Actions

Authored by bytesofman on Oct 17 2024, 21:11.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC14ee38d15f4b: [ecash-agora] syntax replace == with ===

Summary

We only want '==' in JS for oddly specific cases. Not the case in these instances.

Test Plan

CI test (npm test)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 17 2024, 21:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2024, 21:11

Harbormaster completed remote builds in B30635: Diff 50151.Oct 17 2024, 21:20

bytesofman added a child revision: D16920: [ecash-agora] Get true minimum buy amounts for agora offers.Oct 17 2024, 22:31

bytesofman published this revision for review.Oct 17 2024, 22:31

PiRK accepted this revision.Oct 18 2024, 06:21

This revision is now accepted and ready to land.Oct 18 2024, 06:21

Closed by commit rABC14ee38d15f4b: [ecash-agora] syntax replace == with === (authored by bytesofman). · Explain WhyOct 18 2024, 10:23

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC14ee38d15f4b: [ecash-agora] syntax replace == with ===.

Revision Contents
Changeset List

Path

Size

modules/

ecash-agora/

src/

agora.ts

6 lines

oneshot.ts

2 lines

partial.ts

25 lines

Diff 50170

View Options

modules/ecash-agora/src/agora.ts

View Options

modules/ecash-agora/src/oneshot.ts

View Options

modules/ecash-agora/src/partial.ts

[ecash-agora] syntax replace == with ===ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50170

modules/ecash-agora/src/agora.ts

modules/ecash-agora/src/oneshot.ts

modules/ecash-agora/src/partial.ts

[ecash-agora] syntax replace == with ===
ClosedPublic
Actions

Revision Contents
Changeset List