Paths

Table of Contentst

Differential D16924

[Cashtab] Separate scroll styling for portability
ClosedPublic
Actions

Authored by bytesofman on Oct 17 2024, 23:49.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4b8c2e5147c9: [Cashtab] Separate scroll styling for portability

Summary

We want to use this on a new component to support agora partial trading. Move it so it can be edited in one place and support multiple components.

Test Plan

npm test, npm start and modal scrollbars still look the same

Diff Detail

Repository

rABC Bitcoin ABC

Branch

modal-scroll-portable

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30644
Build 60804: Build Diff	cashtab-tests · ecash-lib-tests
Build 60803: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 17 2024, 23:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2024, 23:49

bytesofman edited the test plan for this revision. (Show Details)Oct 17 2024, 23:49

Harbormaster completed remote builds in B30644: Diff 50160.Oct 17 2024, 23:53

bytesofman published this revision for review.Oct 18 2024, 00:05

PiRK accepted this revision.Oct 18 2024, 06:24

This revision is now accepted and ready to land.Oct 18 2024, 06:24

Closed by commit rABC4b8c2e5147c9: [Cashtab] Separate scroll styling for portability (authored by bytesofman). · Explain WhyOct 18 2024, 10:25

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC4b8c2e5147c9: [Cashtab] Separate scroll styling for portability.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Common/

Atoms.js

21 lines

Modal.js

18 lines

Diff 50160

View Options

cashtab/src/components/Common/Atoms.js