Page MenuHomePhabricator
Differential D16925

[Cashtab] New formatting method for getting decimals for very small xec values
ClosedPublic
Actions

Authored by bytesofman on Oct 18 2024, 00:04.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa147deb6003c: [Cashtab] New formatting method for getting decimals for very small xec values
Summary

Agora partials can be priced in nanosatoshis. We want a way to render these as localeStrings with appropriate minimimumFractionDigits.

Add new formatting helper functions.

Not implemented in this diff, see D16846 for the purpose.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
get-decimals-formatting
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcashtab/src/utils/__tests__/formatting.test.js:136ESLINTjest/no-focused-tests
Unit
No Test Coverage
Build Status
Buildable 30645
Build 60806: Build Diffecash-lib-tests · cashtab-tests
Build 60805: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 18 2024, 00:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2024, 00:04
Harbormaster completed remote builds in B30645: Diff 50161.Oct 18 2024, 00:04
bytesofman updated this revision to Diff 50162.Oct 18 2024, 00:04

lint

bytesofman updated this revision to Diff 50163.Oct 18 2024, 00:05

use const

Harbormaster completed remote builds in B30646: Diff 50162.Oct 18 2024, 00:09
Harbormaster completed remote builds in B30647: Diff 50163.
bytesofman published this revision for review.Oct 18 2024, 00:12
bytesofman updated this revision to Diff 50167.Oct 18 2024, 03:52

improve function, add other related price formatting function

Harbormaster completed remote builds in B30651: Diff 50167.Oct 18 2024, 03:52
bytesofman updated this revision to Diff 50168.Oct 18 2024, 03:52

lint

bytesofman edited the summary of this revision. (Show Details)Oct 18 2024, 03:53
Harbormaster completed remote builds in B30652: Diff 50168.Oct 18 2024, 03:57
PiRK added a subscriber: PiRK.Oct 18 2024, 06:30
PiRK added inline comments.
cashtab/src/utils/fixtures/vectors.js
454 ↗(On Diff #50168)
PiRK requested changes to this revision.Oct 18 2024, 06:32

There is a test that does not do what it claims to do.
Otherwise looks good.

This revision now requires changes to proceed.Oct 18 2024, 06:32
bytesofman updated this revision to Diff 50174.Oct 18 2024, 10:28

fix accidentally copied unit test

bytesofman marked an inline comment as done.Oct 18 2024, 10:28
Harbormaster completed remote builds in B30653: Diff 50174.Oct 18 2024, 11:03
PiRK accepted this revision.Oct 18 2024, 12:46
This revision is now accepted and ready to land.Oct 18 2024, 12:46
Closed by commit rABCa147deb6003c: [Cashtab] New formatting method for getting decimals for very small xec values (authored by bytesofman). · Explain WhyOct 18 2024, 12:51
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCa147deb6003c: [Cashtab] New formatting method for getting decimals for very small xec values.

Revision Contents
Changeset List

PathSize
cashtab/
src/
utils/
__tests__/
10 lines
fixtures/
30 lines
19 lines

Diff 50161

View Options

cashtab/src/utils/__tests__/formatting.test.js

Loading...
View Options

cashtab/src/utils/fixtures/vectors.js

Loading...
View Options

cashtab/src/utils/formatting.js

Loading...