Page MenuHomePhabricator
Differential D16931

[ecash-herald] Improve formatting of daily summary msgs
ClosedPublic
Actions

Authored by bytesofman on Oct 18 2024, 12:32.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC1df9ffb6e05b: [ecash-herald] Improve formatting of daily summary msgs
Summary

Add emojis, basic cleanup of the message

Test Plan

npm test and review before and after screenshot

as-is (msg went out yesterday)

image.png (653×474 px, 78 KB)

after this diff

image.png (708×387 px, 90 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herad-summary-improvements
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30663
Build 60842: Build Diffecash-herald-tests
Build 60841: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 18 2024, 12:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2024, 12:32
bytesofman published this revision for review.Oct 18 2024, 12:33
bytesofman edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B30660: Diff 50182.Oct 18 2024, 12:34
emack requested changes to this revision.Oct 18 2024, 13:02
emack added a subscriber: emack.
emack added inline comments.
apps/ecash-herald/src/parse.js
2358 ↗(On Diff #50182)

what was the reason for removing this? It's quite relevant considering you're still only showing the top MINERS_TO_SHOW

2393 ↗(On Diff #50182)

as above

This revision now requires changes to proceed.Oct 18 2024, 13:02
bytesofman marked 2 inline comments as done.Oct 18 2024, 13:19
bytesofman added inline comments.
apps/ecash-herald/src/parse.js
2358 ↗(On Diff #50182)

tightens up the msg but, yeah, it is kind of ambiguous without it. re-added.

bytesofman updated this revision to Diff 50189.Oct 18 2024, 13:19
bytesofman marked an inline comment as done.

top 3 back in

bytesofman edited the test plan for this revision. (Show Details)Oct 18 2024, 13:19
Harbormaster completed remote builds in B30663: Diff 50189.Oct 18 2024, 13:37
emack accepted this revision.Oct 18 2024, 15:24
This revision is now accepted and ready to land.Oct 18 2024, 15:24
Closed by commit rABC1df9ffb6e05b: [ecash-herald] Improve formatting of daily summary msgs (authored by bytesofman). · Explain WhyOct 18 2024, 15:47
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC1df9ffb6e05b: [ecash-herald] Improve formatting of daily summary msgs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
5 lines
src/
130 lines
test/
74 lines

Diff 50189

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/parse.test.js

Loading...