Paths

Table of Contentst

Differential D16959

[ecash-herald] Parse app txs in daily summaries
ClosedPublic
Actions

Authored by bytesofman on Oct 22 2024, 20:28.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7ef03ae89de4: [ecash-herald] Parse app txs in daily summaries

Summary

App txs are an important KPI to track. More apps (with real users), more inelastic demand.

Test Plan

npm test, review screenshot

yesterday's summary (before this diff)

image.png (708×398 px, 91 KB)

24 hr summary from rightnow, with this diff (only bottom half, which has changed):

image.png (484×398 px, 62 KB)

after feedback and new type:

image.png (472×366 px, 63 KB)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-app-txs-summary

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30751
Build 61018: Build Diff	ecash-herald-tests
Build 61017: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 22 2024, 20:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2024, 20:28

Harbormaster completed remote builds in B30747: Diff 50294.Oct 22 2024, 20:30

bytesofman published this revision for review.Oct 22 2024, 20:30

bytesofman edited the test plan for this revision. (Show Details)

bytesofman added inline comments.

apps/ecash-herald/src/parse.js
2358 ↗	(On Diff #50294)	unlikely we see more than 1,000 blocks but we see this now in the tests as an artifact of using real txs over many days in the mocks
2469 ↗	(On Diff #50294)	not really a change here -- we just move cashfusion txs into the app txs, instead of "before" token txs

emack requested changes to this revision.Oct 22 2024, 22:56

emack added a subscriber: emack.

emack added inline comments.

apps/ecash-herald/constants/lokad.js
20 ↗	(On Diff #50294)	you can use this tx for the test data

This revision now requires changes to proceed.Oct 22 2024, 22:56

bytesofman marked an inline comment as done.Oct 22 2024, 23:13

link to apps with known URLs, add new app type

bytesofman edited the test plan for this revision. (Show Details)Oct 22 2024, 23:13

Harbormaster completed remote builds in B30751: Diff 50298.Oct 22 2024, 23:15

emack accepted this revision.Oct 22 2024, 23:23

This revision is now accepted and ready to land.Oct 22 2024, 23:23

Closed by commit rABC7ef03ae89de4: [ecash-herald] Parse app txs in daily summaries (authored by bytesofman). · Explain WhyOct 22 2024, 23:29

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC7ef03ae89de4: [ecash-herald] Parse app txs in daily summaries.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

constants/

31 lines

src/

101 lines

test/

mocks/

364 lines

56 lines

Diff 50298

apps/ecash-herald/constants/lokad.js

Loading...

apps/ecash-herald/src/parse.js

Loading...

apps/ecash-herald/test/mocks/dailyTxs.js

Loading...

apps/ecash-herald/test/parse.test.js

Loading...