Page MenuHomePhabricator
Differential D16968

[secp256k1] Backport "'Schnorrsig API overhaul' fixups"
ClosedPublic
Actions

Authored by tobias_ruck on Oct 23 2024, 16:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups"
Summary

Bitcoin Core added some later fixups, which make sense to be backported after we added D16958.

This is a backport of secp256k1#963.

Test Plan

ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Oct 23 2024, 16:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2024, 16:11
tobias_ruck requested review of this revision.Oct 23 2024, 16:11
teamcity edited the summary of this revision. (Show Details)Oct 23 2024, 16:11
Harbormaster completed remote builds in B30763: Diff 50317.Oct 23 2024, 16:33
Fabien requested changes to this revision.Oct 23 2024, 20:32
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/ci/linux-debian.Dockerfile
12 ↗(On Diff #50317)

This is all that is needed, you went a bit too far here :)

This revision now requires changes to proceed.Oct 23 2024, 20:32
tobias_ruck added inline comments.Oct 23 2024, 20:39
src/secp256k1/ci/linux-debian.Dockerfile
12 ↗(On Diff #50317)

ah, well I just ported what they had, but that makes more sense :)

tobias_ruck updated this revision to Diff 50341.Oct 23 2024, 20:42

remove unneeded installs

Fabien accepted this revision.Oct 23 2024, 20:44
This revision is now accepted and ready to land.Oct 23 2024, 20:44
Harbormaster completed remote builds in B30782: Diff 50341.Oct 23 2024, 20:56
teamcity added a comment.Oct 23 2024, 20:56
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 50343.Oct 23 2024, 21:00

rebase onto master

Harbormaster completed remote builds in B30784: Diff 50343.Oct 23 2024, 21:35
Closed by commit rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups" (authored by tobias_ruck). · Explain WhyOct 23 2024, 22:22
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".

Revision Contents
Changeset List

PathSize
src/
secp256k1/
21 lines
ci/
1 line
include/
2 lines
src/
1 line
1 line
modules/
schnorrsig/
4 lines
4 lines

Diff 50345

View Options

src/secp256k1/.cirrus.yml

Loading...
View Options

src/secp256k1/ci/linux-debian.Dockerfile

Loading...
View Options

src/secp256k1/include/secp256k1_schnorrsig.h

Loading...
View Options

src/secp256k1/src/ecmult.h

Loading...
View Options

src/secp256k1/src/ecmult_gen.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/main_impl.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/tests_impl.h

Loading...