Page MenuHomePhabricator

[secp256k1] Backport "'Schnorrsig API overhaul' fixups"
ClosedPublic

Authored by tobias_ruck on Wed, Oct 23, 16:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups"
Summary

Bitcoin Core added some later fixups, which make sense to be backported after we added D16958.

This is a backport of secp256k1#963.

Test Plan

ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Wed, Oct 23, 20:32
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/ci/linux-debian.Dockerfile
12 ↗(On Diff #50317)

This is all that is needed, you went a bit too far here :)

This revision now requires changes to proceed.Wed, Oct 23, 20:32
src/secp256k1/ci/linux-debian.Dockerfile
12 ↗(On Diff #50317)

ah, well I just ported what they had, but that makes more sense :)

This revision is now accepted and ready to land.Wed, Oct 23, 20:44
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.