Page MenuHomePhabricator
Differential D16958

[secp256k1] Backport "Schnorrsig API overhaul"
ClosedPublic
Actions

Authored by tobias_ruck on Oct 22 2024, 17:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc422b039a7f5: [secp256k1] Backport "Schnorrsig API overhaul"
Summary

Bitcoin Core changed the C API for BIP340 Schnorr signatures within secp256k1. We don't use them in Bitcoin ABC, so thus far this backport was not needed.

This is a backport of secp256k1#844.

Now we do need this backport mostly for secp256k1_schnorrsig_sign_custom for porting rust-secp256k1 to the secp256k1 library of this repo.

Depends on D16957.

Test Plan

ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Oct 22 2024, 17:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2024, 17:48
teamcity edited the summary of this revision. (Show Details)Oct 22 2024, 17:48
tobias_ruck edited the summary of this revision. (Show Details)Oct 22 2024, 17:50
tobias_ruck edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B30741: Diff 50287.Oct 22 2024, 18:19
tobias_ruck published this revision for review.Oct 22 2024, 19:29
tobias_ruck updated this revision to Diff 50290.Oct 22 2024, 19:45

rebase onto master

Harbormaster completed remote builds in B30743: Diff 50290.Oct 22 2024, 19:59
tobias_ruck added a child revision: D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.Oct 22 2024, 20:16
Fabien added a subscriber: Fabien.Oct 23 2024, 09:22

Please also backport the fixups https://github.com/bitcoin-core/secp256k1/pull/963.
Because it's shnorrsig it's fine to do it in another diff.

Fabien accepted this revision.Oct 23 2024, 09:30
This revision is now accepted and ready to land.Oct 23 2024, 09:30
Fabien requested changes to this revision.Oct 23 2024, 09:31

The change to the README is missing

This revision now requires changes to proceed.Oct 23 2024, 09:31
tobias_ruck updated this revision to Diff 50316.Oct 23 2024, 16:03

also backport README change

Fabien accepted this revision.Oct 23 2024, 16:04
This revision is now accepted and ready to land.Oct 23 2024, 16:04
tobias_ruck mentioned this in D16968: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".Oct 23 2024, 16:11
Harbormaster completed remote builds in B30762: Diff 50316.Oct 23 2024, 16:23
Closed by commit rABCc422b039a7f5: [secp256k1] Backport "Schnorrsig API overhaul" (authored by tobias_ruck). · Explain WhyOct 23 2024, 16:35
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCc422b039a7f5: [secp256k1] Backport "Schnorrsig API overhaul".
tobias_ruck mentioned this in rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".Oct 23 2024, 22:22

Revision Contents
Changeset List

PathSize
src/
secp256k1/
1 line
include/
25 lines
115 lines
src/
15 lines
modules/
schnorrsig/
61 lines
24 lines
229 lines
13 lines
33 lines
2 lines

Diff 50320

View Options

src/secp256k1/README.md

Loading...
View Options

src/secp256k1/include/secp256k1.h

Loading...
View Options

src/secp256k1/include/secp256k1_schnorrsig.h

Loading...
View Options

src/secp256k1/src/bench_schnorrsig.c

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/main_impl.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/tests_exhaustive_impl.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/tests_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...
View Options

src/secp256k1/src/valgrind_ctime_test.c

Loading...