Paths

Table of Contentst

Differential D16958

[secp256k1] Backport "Schnorrsig API overhaul"
ClosedPublic
Actions

Authored by tobias_ruck on Oct 22 2024, 17:48.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc422b039a7f5: [secp256k1] Backport "Schnorrsig API overhaul"

Summary

Bitcoin Core changed the C API for BIP340 Schnorr signatures within secp256k1. We don't use them in Bitcoin ABC, so thus far this backport was not needed.

This is a backport of secp256k1#844.

Now we do need this backport mostly for secp256k1_schnorrsig_sign_custom for porting rust-secp256k1 to the secp256k1 library of this repo.

Depends on D16957.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secp256k1-backport-PR844

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30743
Build 61002: Build Diff	lint-circular-dependencies · build-secp256k1 · build-without-wallet · build-secp256k1-java · build-secp256k1-bench · build-debug · build-clang-tidy · build-clang · build-diff
Build 61001: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Oct 22 2024, 17:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2024, 17:48

teamcity edited the summary of this revision. (Show Details)Oct 22 2024, 17:48

tobias_ruck edited the summary of this revision. (Show Details)Oct 22 2024, 17:50

tobias_ruck edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B30741: Diff 50287.Oct 22 2024, 18:19

tobias_ruck published this revision for review.Oct 22 2024, 19:29

rebase onto master

Harbormaster completed remote builds in B30743: Diff 50290.Oct 22 2024, 19:59

tobias_ruck added a child revision: D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.Oct 22 2024, 20:16

Please also backport the fixups https://github.com/bitcoin-core/secp256k1/pull/963.
Because it's shnorrsig it's fine to do it in another diff.

Fabien accepted this revision.Oct 23 2024, 09:30

This revision is now accepted and ready to land.Oct 23 2024, 09:30

The change to the README is missing

This revision now requires changes to proceed.Oct 23 2024, 09:31

also backport README change

Fabien accepted this revision.Oct 23 2024, 16:04

This revision is now accepted and ready to land.Oct 23 2024, 16:04

tobias_ruck mentioned this in D16968: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".Oct 23 2024, 16:11

Harbormaster completed remote builds in B30762: Diff 50316.Oct 23 2024, 16:23

Closed by commit rABCc422b039a7f5: [secp256k1] Backport "Schnorrsig API overhaul" (authored by tobias_ruck). · Explain WhyOct 23 2024, 16:35

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCc422b039a7f5: [secp256k1] Backport "Schnorrsig API overhaul".

tobias_ruck mentioned this in rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".Oct 23 2024, 22:22

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

include/

25 lines

secp256k1_schnorrsig.h

115 lines

src/

bench_schnorrsig.c

15 lines

modules/

schnorrsig/

61 lines

tests_exhaustive_impl.h

24 lines

229 lines

13 lines

33 lines

valgrind_ctime_test.c

2 lines

Diff 50290

src/secp256k1/include/secp256k1.h

Loading...

src/secp256k1/include/secp256k1_schnorrsig.h

Loading...

src/secp256k1/src/bench_schnorrsig.c

Loading...

src/secp256k1/src/modules/schnorrsig/main_impl.h

Loading...

src/secp256k1/src/modules/schnorrsig/tests_exhaustive_impl.h

Loading...

src/secp256k1/src/modules/schnorrsig/tests_impl.h

Loading...

src/secp256k1/src/secp256k1.c

Loading...

src/secp256k1/src/tests.c

Loading...

src/secp256k1/src/valgrind_ctime_test.c

Loading...