Page MenuHomePhabricator
Differential D16969

[ecash-herald] patch cron bug to send daily summaries at midnight UTC
ClosedPublic
Actions

Authored by bytesofman on Wed, Oct 23, 17:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa34a9e57af9f: [ecash-herald] patch cron bug to send daily summaries at midnight UTC
Summary

Send every day not every hour

Test Plan

confirm in https://www.npmjs.com/package/cron docs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-time-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30779
Build 61073: Build Diffecash-herald-tests
Build 61072: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Oct 23, 17:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 23, 17:04
bytesofman published this revision for review.Wed, Oct 23, 17:07
bytesofman edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B30768: Diff 50325.Wed, Oct 23, 17:34
bytesofman updated this revision to Diff 50337.Wed, Oct 23, 19:37

patch bad cron

bytesofman retitled this revision from [ecash-herald] Send daily summaries at midnight UTC to [ecash-herald] patch cron bug to send daily summaries at midnight UTC.Wed, Oct 23, 19:38
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B30779: Diff 50337.Wed, Oct 23, 19:38
Fabien accepted this revision.Wed, Oct 23, 20:27
Fabien added a subscriber: Fabien.

I had to look at the doc to understand why there were 6 fields and not 5. You should add the cron header in a comment in the line above

This revision is now accepted and ready to land.Wed, Oct 23, 20:27
Closed by commit rABCa34a9e57af9f: [ecash-herald] patch cron bug to send daily summaries at midnight UTC (authored by bytesofman). · Explain WhyWed, Oct 23, 21:03
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCa34a9e57af9f: [ecash-herald] patch cron bug to send daily summaries at midnight UTC.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
2 lines

Diff 50337

View Options

apps/ecash-herald/index.js

Loading...