Parse agora buy, sell, and cancel txs in Cashtab tx history
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC31e27d47cace: [Cashtab] Parse agora oneshot buys and sells
npm test
seems to also work on agora partials
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
back out unrelated line break, improve conditional organization for agora renderedTxType
| modules/ecash-agora/src/agora.ts | ||
|---|---|---|
| 890 ↗ | (On Diff #50348) | we still aren't publishing ecash-agora. I don't think there is any reason not to export this, since you can see in this diff how it could be useful to another application. Arguably we should export something more like isAgoraCancel(inputScript) ... but at this point I don't think we have enough info to know what this method would look like. Cashtab's tx history rendering case is pretty specific. For example, we can reasonably assume the input is either an agora buy or an agora cancel. |