Paths

Table of Contentst

Differential D16997

[64-bit ints] Refactor `CScriptNum` to require setting `nMaxNumSize`
DraftPublic
Actions

Authored by tobias_ruck on Fri, Oct 25, 00:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

Currently, CScriptNum's constructor and IsMinimallyEncoded have a default for nMaxNumSize, which defaults to 4 (eCash's maximum integer size).

For upgrading Script integers from 32-bit to 64-bit, having to make the integer size explicit allows us to upgrade them based on a script flag.

This has no change in behavior.

Depends on D16996.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

interpreter-refactor-script-num-size

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30835
Build 61183: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang · build-debug · build-diff
Build 61182: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Fri, Oct 25, 00:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Oct 25, 00:21

tobias_ruck edited the summary of this revision. (Show Details)Fri, Oct 25, 00:22

Harbormaster completed remote builds in B30827: Diff 50418.Fri, Oct 25, 00:59

rebase, also do the same change with ScriptNum10

Harbormaster completed remote builds in B30835: Diff 50429.Fri, Oct 25, 09:20

tobias_ruck added a child revision: D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -=.Fri, Oct 25, 09:55

Revision Contents
Changeset List

Path

Size

src/

core_write.cpp

5 lines

script/

interpreter.cpp

33 lines

script.h

9 lines

test/

monolith_opcodes_tests.cpp

6 lines

scriptnum10.h

4 lines

scriptnum_tests.cpp

12 lines

Diff 50429

View Options

src/core_write.cpp

View Options

src/script/interpreter.cpp

View Options

src/script/script.h

View Options

src/test/monolith_opcodes_tests.cpp

View Options

src/test/scriptnum10.h

View Options

src/test/scriptnum_tests.cpp

[64-bit ints] Refactor `CScriptNum` to require setting `nMaxNumSize`DraftPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50429

src/core_write.cpp

src/script/interpreter.cpp

src/script/script.h

src/test/monolith_opcodes_tests.cpp

src/test/scriptnum10.h

src/test/scriptnum_tests.cpp

[64-bit ints] Refactor `CScriptNum` to require setting `nMaxNumSize`
DraftPublic
Actions

Revision Contents
Changeset List