Page MenuHomePhabricator

[qa] fix flaky abc-magnetic-anomaly-activation.py
ClosedPublic

Authored by schancel on Aug 27 2018, 08:10.

Details

Summary

Currently, this test has a tranasction generator for a specific size.
It slowly grows the transaction padding to ensure it is exactly 101 bytes.
However, if the penultimate iteration of the loop generates a padding with
a leftmost bit of zero, and the ultimate run generates a padding with a
leftmost bit of 1, the test will fail.

This commit ensure the leftmost bit is always 1.

Test Plan

Run in a loop for 100 runs:

./test/functional/test_runner.py abc-magnetic-anomaly-activation.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Aug 27 2018, 08:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 27 2018, 08:10
deadalnix accepted this revision.Aug 27 2018, 13:31
This revision is now accepted and ready to land.Aug 27 2018, 13:31
jasonbcox accepted this revision.Aug 27 2018, 14:23
This revision was automatically updated to reflect the committed changes.