Paths

Table of Contentst

Differential D17014

[Cashtab] Fix bug in agora tx parsing
ClosedPublic
Actions

Authored by bytesofman on Sat, Oct 26, 18:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7467e93e04be: [Cashtab] Fix bug in agora tx parsing

Summary

When I patched "we have to look at all the inputs to find the p2sh" -- I was still checking only the inputs[0] input script.

Fix.

Test Plan

npm test (confirms txs are parsed correctly)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch-tx-parsing-again

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30853
Build 61219: Build Diff	cashtab-tests
Build 61218: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sat, Oct 26, 18:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Oct 26, 18:22

remove confused comment

bytesofman edited the test plan for this revision. (Show Details)Sat, Oct 26, 18:24

bytesofman published this revision for review.Sat, Oct 26, 18:41

Fabien accepted this revision.Sat, Oct 26, 18:45

This revision is now accepted and ready to land.Sat, Oct 26, 18:45

Harbormaster completed remote builds in B30853: Diff 50457.Sat, Oct 26, 18:55

Harbormaster completed remote builds in B30854: Diff 50458.Sat, Oct 26, 18:59

Closed by commit rABC7467e93e04be: [Cashtab] Fix bug in agora tx parsing (authored by bytesofman). · Explain WhySat, Oct 26, 19:05

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC7467e93e04be: [Cashtab] Fix bug in agora tx parsing.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Home/

Tx/

index.js

7 lines

Diff 50457

View Options

cashtab/src/components/Home/Tx/index.js

[Cashtab] Fix bug in agora tx parsingClosedPublicActions