Page MenuHomePhabricator

[Cashtab] Improved styling for OrderBook
AcceptedPublic

Authored by bytesofman on Thu, Oct 31, 12:46.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

Depends on D17051

Styling improvement for OrderBook components. Not to be treated as final.

Key changes

  • If we have fewer than 4 offers, we render the tokenId on top of the depth bars
  • Use all available horizontal space (wider depth bars)
  • Use all available horizontal space for slider
  • Add new noIcon param, which will render an OrderBook with depth bars only (for planned implementation on token landing page)
Test Plan

npm test, check screenshots. Still available improvements but review this for "is this better than what we have"

OrderBook with 2 offers

image.png (480×471 px, 52 KB)

OrderBook with 4+ offers

image.png (418×469 px, 49 KB)

Orderbook with noIcon

image.png (386×469 px, 33 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
orderbook-style-improvements
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30940
Build 61383: Build Diffcashtab-tests
Build 61382: arc lint + arc unit