Differential D17067

Deprecate the address_type field of the getnewaddress RPC
ClosedPublic
Actions

Authored by Fabien on Mon, Nov 4, 09:30.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC346ecaef2c58: Deprecate the address_type field of the getnewaddress RPC

Summary

And clarify the documentation. This field is very misleading as it does exactly nothing in our codebase and is only a bitcoin compatibility field.
Since it's an optional parameter there is no need to create a -deprecated_rpc option here.

Depends on D17066.

Test Plan

bitcoin-cli help getnewaddress

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Nov 4, 09:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 4, 09:30

Fabien requested review of this revision.Mon, Nov 4, 09:30

Fabien edited the summary of this revision. (Show Details)Mon, Nov 4, 09:40

Fabien added a parent revision: D17066: Bump version to 0.30.4.

PiRK accepted this revision.Mon, Nov 4, 09:47

This revision is now accepted and ready to land.Mon, Nov 4, 09:47

Harbormaster completed remote builds in B30981: Diff 50634.Mon, Nov 4, 09:49

Closed by commit rABC346ecaef2c58: Deprecate the address_type field of the getnewaddress RPC (authored by Fabien). · Explain WhyMon, Nov 4, 10:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC346ecaef2c58: Deprecate the address_type field of the getnewaddress RPC.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

6 lines

src/

wallet/

rpcwallet.cpp

14 lines

Diff 50636

View Options

doc/release-notes.md