[Cashtab] Improve flakiness in orderbook tests
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 6, 18:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa2ed269a3d3c: [Cashtab] Improve flakiness in orderbook tests

Summary

The min amounts are calculated, so can have a race condition here.

Use await screen.findByText for values that are expected to appear after async.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Wed, Nov 6, 18:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 18:09

Harbormaster completed remote builds in B31038: Diff 50711.Wed, Nov 6, 18:12

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field ======
Error: expect(element).toHaveValue(chicken.xec?amount=500.123)

Expected the element to have value:
  chicken.xec?amount=500.123
Received:
  chicken.xec?amount=500.23
    at Object.toHaveValue (/work/cashtab/src/components/Send/__tests__/SendXec.test.js:815:32)

Each failure log is accessible here:
CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field

In D17090#387775, @teamcity wrote:
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:
====== CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field ======
Error: expect(element).toHaveValue(chicken.xec?amount=500.123)

Expected the element to have value:
  chicken.xec?amount=500.123
Received:
  chicken.xec?amount=500.23
    at Object.toHaveValue (/work/cashtab/src/components/Send/__tests__/SendXec.test.js:815:32)
Each failure log is accessible here:
CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field