Page MenuHomePhabricator
Differential D17119

[ecash-herald] Present daily total volume for agora
ClosedPublic
Actions

Authored by bytesofman on Tue, Nov 12, 19:48.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC847bb4b29c66: [ecash-herald] Present daily total volume for agora
Summary

Depends on D17118

Calculate and present total agora volume for partial and oneshot txs.

Later will also get this information on a per-token basis. But we want the total summary as well, so do that first.

Test Plan

npm test

image.png (503×470 px, 91 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-patch-apptxs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31103
Build 61707: Build Diffecash-herald-tests
Build 61706: arc lint + arc unit

Event Timeline

bytesofman created this revision.Tue, Nov 12, 19:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 12, 19:48
Harbormaster completed remote builds in B31103: Diff 50805.Tue, Nov 12, 19:50
bytesofman published this revision for review.Tue, Nov 12, 19:52
bytesofman edited the test plan for this revision. (Show Details)
bytesofman added inline comments.
apps/ecash-herald/src/parse.ts
3148

we need to improve the satsToFormattedValue function to work with the variables in the daily summaries. this should be a separate diff.

emack accepted this revision.Tue, Nov 12, 23:11
This revision is now accepted and ready to land.Tue, Nov 12, 23:11
Closed by commit rABC847bb4b29c66: [ecash-herald] Present daily total volume for agora (authored by bytesofman). · Explain WhyWed, Nov 13, 01:01
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC847bb4b29c66: [ecash-herald] Present daily total volume for agora.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
2 lines
src/
68 lines
test/
6 lines

Diff 50805

View Options

apps/ecash-herald/config.ts

Loading...
View Options

apps/ecash-herald/src/parse.ts

Loading...
View Options

apps/ecash-herald/test/parse.test.ts

Loading...