Page MenuHomePhabricator
Differential D17128

[Cashtab] More improvements to agora partial sale tx parsing
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 13, 05:08.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCd705d989c04c: [Cashtab] More improvements to agora partial sale tx parsing
Summary

Patch a bug in how agora txs are parsed so that (edge-case) wallets with multiple paths do not double or tripple-count agora amounts.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
another-agora-sale-tx-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31119
Build 61739: Build Diffcashtab-tests
Build 61738: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Nov 13, 05:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 13, 05:08
Harbormaster completed remote builds in B31119: Diff 50828.Wed, Nov 13, 05:12
bytesofman updated this revision to Diff 50833.Wed, Nov 13, 14:41

do not count soldAmount more than once for different wallet paths

Harbormaster completed remote builds in B31122: Diff 50833.Wed, Nov 13, 14:50
bytesofman published this revision for review.Wed, Nov 13, 14:56
bytesofman added inline comments.
cashtab/src/components/Home/Tx/index.js
822 ↗(On Diff #50833)

this is "the change" in this diff

for sold amount, we just want to count the qty that goes to the non-p2sh output

we do not want to count this quantity for every path the wallet might have.

all cashtab wallets are created with only one path now .... but legacy users like me will have path145, path245 -- causing sold qty to be double or tripple counted without this fix.

emack added a subscriber: emack.Wed, Nov 13, 21:47

summary and test plan are still TBD?

bytesofman edited the summary of this revision. (Show Details)Wed, Nov 13, 23:16
bytesofman edited the test plan for this revision. (Show Details)
In D17128#388782, @emack wrote:

summary and test plan are still TBD?

oops, updated

emack accepted this revision.Thu, Nov 14, 10:32
This revision is now accepted and ready to land.Thu, Nov 14, 10:32
Closed by commit rABCd705d989c04c: [Cashtab] More improvements to agora partial sale tx parsing (authored by bytesofman). · Explain WhyThu, Nov 14, 13:40
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCd705d989c04c: [Cashtab] More improvements to agora partial sale tx parsing.

Revision Contents
Changeset List

PathSize
cashtab/
src/
chronik/
fixtures/
220 lines
7 lines
components/
Home/
Tx/
__tests__/
68 lines

Diff 50828

View Options

cashtab/src/chronik/fixtures/mocks.js

Loading...
View Options

cashtab/src/chronik/fixtures/vectors.js

Loading...
View Options

cashtab/src/components/Home/Tx/__tests__/index.test.js

Loading...