Page MenuHomePhabricator
Differential D17132

net: also wait for exceptional events in Sock::Wait()
ClosedPublic
Actions

Authored by PiRK on Nov 13 2024, 17:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf0f41147f028: net: also wait for exceptional events in Sock::Wait()
Summary

This mimics closely CConnman::SocketEvents() and the underlying
poll(2).

rename ERR to err in sock.cpp::Sock::Accept to fix warning declaration shadows a static data member of 'Sock'

This is a partial backport of core#24356
https://github.com/bitcoin/bitcoin/pull/24356/commits/cc74459768063a923fb6220a4f420eaf211aee7b

Depends on D17131

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 13 2024, 17:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2024, 17:48
PiRK requested review of this revision.Nov 13 2024, 17:48
teamcity edited the summary of this revision. (Show Details)Nov 13 2024, 17:49
PiRK added a child revision: D17133: net: introduce Sock::WaitMany().Nov 13 2024, 17:50
Harbormaster completed remote builds in B31127: Diff 50841.Nov 13 2024, 18:27
PiRK added inline comments.Nov 13 2024, 21:32
src/util/sock.cpp
79 ↗(On Diff #50841)

renamed so as to not shadow the Sock::ERR data member

Fabien accepted this revision.Nov 14 2024, 08:29
This revision is now accepted and ready to land.Nov 14 2024, 08:29
PiRK updated this revision to Diff 50857.Nov 14 2024, 11:38

rebase

Harbormaster completed remote builds in B31141: Diff 50857.Nov 14 2024, 12:09
Closed by commit rABCf0f41147f028: net: also wait for exceptional events in Sock::Wait() (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyNov 18 2024, 06:42
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf0f41147f028: net: also wait for exceptional events in Sock::Wait().

Revision Contents
Changeset List

PathSize
src/
5 lines
util/
23 lines
18 lines

Diff 50916

View Options

src/i2p.cpp

Loading...
View Options

src/util/sock.h

Loading...
View Options

src/util/sock.cpp

Loading...