Paths

Table of Contentst

Differential D17132

net: also wait for exceptional events in Sock::Wait()
AcceptedPublic
Actions

Authored by PiRK on Wed, Nov 13, 17:48.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

This mimics closely CConnman::SocketEvents() and the underlying
poll(2).

rename ERR to err in sock.cpp::Sock::Accept to fix warning declaration shadows a static data member of 'Sock'

This is a partial backport of core#24356
https://github.com/bitcoin/bitcoin/pull/24356/commits/cc74459768063a923fb6220a4f420eaf211aee7b

Depends on D17131

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31141
Build 61783: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 61782: arc lint + arc unit

Event Timeline

PiRK created this revision.Wed, Nov 13, 17:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 13, 17:48

PiRK requested review of this revision.Wed, Nov 13, 17:48

teamcity edited the summary of this revision. (Show Details)Wed, Nov 13, 17:49

PiRK added a child revision: D17133: net: introduce Sock::WaitMany().Wed, Nov 13, 17:50

Harbormaster completed remote builds in B31127: Diff 50841.Wed, Nov 13, 18:27

PiRK added inline comments.Wed, Nov 13, 21:32

src/util/sock.cpp
79 ↗	(On Diff #50841)	renamed so as to not shadow the Sock::ERR data member

Fabien accepted this revision.Thu, Nov 14, 08:29

This revision is now accepted and ready to land.Thu, Nov 14, 08:29

rebase

Harbormaster completed remote builds in B31141: Diff 50857.Thu, Nov 14, 12:09

Revision Contents
Changeset List

Path

Size

src/

i2p.cpp

5 lines

util/

sock.h

23 lines

sock.cpp

18 lines

Diff 50857

View Options

src/i2p.cpp

View Options

src/util/sock.h

View Options

net: also wait for exceptional events in Sock::Wait()AcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50857

src/i2p.cpp

src/util/sock.h

src/util/sock.cpp

net: also wait for exceptional events in Sock::Wait()
AcceptedPublic
Actions

Revision Contents
Changeset List