Paths

Table of Contentst

Differential D17136

[ecash-herald] Standardize the way we convert satoshi values to formatted amounts
ClosedPublic
Actions

Authored by bytesofman on Nov 13 2024, 23:12.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf9a0ab6cb7af: [ecash-herald] Standardize the way we convert satoshi values to formatted…

Summary

The satsToFormatteValue function is specialized for an arcane herald-native object, coingeckoPrices, which was overengineered to support potential changes of fiat currency for the herald. We have never used this feature.

So, refactor herald so that satsToFormattedValue accepts a USD price. This allows us to extend its use into the daily summaries. We implement it there.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 13 2024, 23:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2024, 23:12

Harbormaster completed remote builds in B31137: Diff 50853.Nov 13 2024, 23:14

bytesofman published this revision for review.Nov 13 2024, 23:16

emack accepted this revision.Nov 14 2024, 12:40

This revision is now accepted and ready to land.Nov 14 2024, 12:40

Closed by commit rABCf9a0ab6cb7af: [ecash-herald] Standardize the way we convert satoshi values to formatted… (authored by bytesofman). · Explain WhyNov 14 2024, 13:40

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCf9a0ab6cb7af: [ecash-herald] Standardize the way we convert satoshi values to formatted….

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

103 lines

16 lines

test/

24 lines

47 lines

Diff 50861

apps/ecash-herald/src/parse.ts

Loading...

apps/ecash-herald/src/utils.ts

Loading...

apps/ecash-herald/test/parse.test.ts

Loading...

apps/ecash-herald/test/utils.test.ts

Loading...