Paths

Table of Contentst

Differential D17136

[ecash-herald] Standardize the way we convert satoshi values to formatted amounts
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 13, 23:12.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf9a0ab6cb7af: [ecash-herald] Standardize the way we convert satoshi values to formatted…

Summary

The satsToFormatteValue function is specialized for an arcane herald-native object, coingeckoPrices, which was overengineered to support potential changes of fiat currency for the herald. We have never used this feature.

So, refactor herald so that satsToFormattedValue accepts a USD price. This allows us to extend its use into the daily summaries. We implement it there.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

generalize-price-formatting

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31137
Build 61775: Build Diff	ecash-herald-tests
Build 61774: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Nov 13, 23:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 13, 23:12

Harbormaster completed remote builds in B31137: Diff 50853.Wed, Nov 13, 23:14

bytesofman published this revision for review.Wed, Nov 13, 23:16

emack accepted this revision.Thu, Nov 14, 12:40

This revision is now accepted and ready to land.Thu, Nov 14, 12:40

Closed by commit rABCf9a0ab6cb7af: [ecash-herald] Standardize the way we convert satoshi values to formatted… (authored by bytesofman). · Explain WhyThu, Nov 14, 13:40

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCf9a0ab6cb7af: [ecash-herald] Standardize the way we convert satoshi values to formatted….

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

103 lines

16 lines

test/

24 lines

47 lines

Diff 50853

apps/ecash-herald/src/parse.ts

Loading...

apps/ecash-herald/src/utils.ts

Loading...

apps/ecash-herald/test/parse.test.ts

Loading...

apps/ecash-herald/test/utils.test.ts

Loading...