Differential D1714

Various nits in transactionview.cpp
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 17:05.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGbae3b5a7cb97: Various nits in transactionview.cpp
rABCbae3b5a7cb97: Various nits in transactionview.cpp

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qttxview

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3184
Build 4455: Bitcoin ABC Buildbot (legacy)
Build 4454: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2018, 17:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 17:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Sep 4 2018, 17:26

This revision is now accepted and ready to land.Sep 4 2018, 17:26

Harbormaster failed remote builds in B3184: Diff 4745!Sep 4 2018, 17:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3189: Diff 4755.Sep 4 2018, 18:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCbae3b5a7cb97: Various nits in transactionview.cpp (authored by deadalnix). · Explain WhySep 4 2018, 20:25

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

transactionview.h

13 lines

transactionview.cpp

77 lines

Diff 4745

View Options

src/qt/transactionview.h