Paths

Table of Contentst

Differential D17156

refactor: Take Span in SetSeed
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 18, 10:24.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABCabfd248f0a4b: refactor: Take Span in SetSeed

Summary

This makes calling code less verbose and less fragile. Also, by adding
the CKey::data() member function, it is now possible to call HexStr()
with a CKey object.

This is a backport of core#23409

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Nov 18, 10:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 18, 10:24

PiRK requested review of this revision.Mon, Nov 18, 10:24

teamcity edited the summary of this revision. (Show Details)Mon, Nov 18, 10:24

PiRK added a child revision: D17157: util: Add ParseHex<std::byte>() helper.Mon, Nov 18, 10:28

Harbormaster completed remote builds in B31183: Diff 50928.Mon, Nov 18, 11:11

roqqit accepted this revision.Mon, Nov 18, 17:06

This revision is now accepted and ready to land.Mon, Nov 18, 17:06

Closed by commit rABCabfd248f0a4b: refactor: Take Span in SetSeed (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMon, Nov 18, 19:56

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCabfd248f0a4b: refactor: Take Span in SetSeed.

Revision Contents
Changeset List

Path

Size

src/

key.h

3 lines

key.cpp

6 lines

test/

bip32_tests.cpp

2 lines

key_io_tests.cpp

5 lines

wallet/

rpc/

backup.cpp

2 lines

scriptpubkeyman.cpp

4 lines

wallet.cpp

2 lines

Diff 50943

View Options

src/key.h

View Options

src/key.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/key_io_tests.cpp

View Options

src/wallet/rpc/backup.cpp

View Options

src/wallet/scriptpubkeyman.cpp

View Options

refactor: Take Span in SetSeedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50943

src/key.h

src/key.cpp

src/test/bip32_tests.cpp

src/test/key_io_tests.cpp

src/wallet/rpc/backup.cpp

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.cpp

refactor: Take Span in SetSeed
ClosedPublic
Actions

Revision Contents
Changeset List