Page MenuHomePhabricator
Differential D17158

Handle invalid hex encoding in ParseHex
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 18, 11:10.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC17760e91d644: Handle invalid hex encoding in ParseHex
Summary

Seems a bit confusing to happily accept random bytes and pretend they are hex encoded strings

Added a new TryParseHex function returning an optional. The old function remains an alias, with the fallback to an empty vector. This avoid having to change all existing code and making it needlessly verbose, because it is already properly handling empty vectors.

This is a backport of core#25227

Fix a hex string in checkpoints_tests that was obviously wrong (odd number of hex chars) and now causes ParseHex to return an empty vector.

Depends on D17157

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Nov 18, 11:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 18, 11:10
PiRK requested review of this revision.Mon, Nov 18, 11:10
teamcity edited the summary of this revision. (Show Details)Mon, Nov 18, 11:10
PiRK edited the summary of this revision. (Show Details)Mon, Nov 18, 11:10
PiRK added a parent revision: D17157: util: Add ParseHex<std::byte>() helper.
PiRK added a child revision: D17138: Rework receive buffer pushback.
PiRK mentioned this in D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.Mon, Nov 18, 11:20
Harbormaster completed remote builds in B31185: Diff 50930.Mon, Nov 18, 11:40
PiRK added a child revision: D17159: util: optimize HexStr.Mon, Nov 18, 15:47
roqqit accepted this revision.Mon, Nov 18, 17:22
This revision is now accepted and ready to land.Mon, Nov 18, 17:22
Closed by commit rABC17760e91d644: Handle invalid hex encoding in ParseHex (authored by MarcoFalke <6399679+MarcoFalke@users.noreply.github.com>, committed by PiRK). · Explain WhyMon, Nov 18, 19:57
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC17760e91d644: Handle invalid hex encoding in ParseHex.
PiRK removed a child revision: D17138: Rework receive buffer pushback.Mon, Nov 18, 20:01
PiRK removed a child revision: D17159: util: optimize HexStr.

Revision Contents
Changeset List

PathSize
src/
test/
2 lines
45 lines
util/
10 lines
10 lines

Diff 50945

View Options

src/test/checkpoints_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...