Paths

Table of Contentst

Differential D17164

[ecash-herald] Patch bug in tracking per-token agora volume
ClosedPublic
Actions

Authored by bytesofman on Tue, Nov 19, 22:54.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC7d2e784926a3: [ecash-herald] Patch bug in tracking per-token agora volume

Summary

We were over-writing the 'volume' key each time this function was called, leading to under-reporting of per-token volume counts.

Test Plan

npm test, check screenshots.

before:

after:

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-sort-vol

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31210
Build 61920: Build Diff	ecash-herald-tests
Build 61919: arc lint + arc unit

Event Timeline

bytesofman created this revision.Tue, Nov 19, 22:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 19, 22:54

bytesofman edited the test plan for this revision. (Show Details)Tue, Nov 19, 22:55

Harbormaster completed remote builds in B31210: Diff 50964.Tue, Nov 19, 22:56

bytesofman published this revision for review.Tue, Nov 19, 23:07

emack accepted this revision.Wed, Nov 20, 06:25

This revision is now accepted and ready to land.Wed, Nov 20, 06:25

Closed by commit rABC7d2e784926a3: [ecash-herald] Patch bug in tracking per-token agora volume (authored by bytesofman). · Explain WhyWed, Nov 20, 14:33

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC7d2e784926a3: [ecash-herald] Patch bug in tracking per-token agora volume.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.ts

1 line

Diff 50964

View Options

apps/ecash-herald/src/parse.ts

[ecash-herald] Patch bug in tracking per-token agora volumeClosedPublicActions