Page MenuHomePhabricator
Differential D17178

[Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt
ClosedPublic
Actions

Authored by tobias_ruck on Nov 21 2024, 13:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbc5c8fabb06c: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt
Summary

If someone wants to rename the project, they'd also need to change these variables.

Instead, we fix this by using CMAKE_PROJECT_NAME when building the config header.

Test Plan

ninja check && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Nov 21 2024, 13:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2024, 13:36
tobias_ruck requested review of this revision.Nov 21 2024, 13:36
tobias_ruck updated this revision to Diff 51010.Nov 21 2024, 13:40

we already have CMAKE_PROJECT_NAME, use that instead of making our own

tobias_ruck updated this revision to Diff 51011.Nov 21 2024, 13:41

remove unrelated changes

tobias_ruck retitled this revision from [Cmake] Add ROOT_PROJECT_NAME, use in src/config/CMakeLists.txt to [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.Nov 21 2024, 13:47
tobias_ruck edited the summary of this revision. (Show Details)
Fabien added a comment.Nov 21 2024, 13:53

@bot guix-linux

teamcity awarded a token.Nov 21 2024, 13:53
Harbormaster completed remote builds in B31244: Diff 51009.Nov 21 2024, 13:58
Harbormaster completed remote builds in B31245: Diff 51010.Nov 21 2024, 14:08
Harbormaster completed remote builds in B31246: Diff 51011.Nov 21 2024, 14:23
Fabien accepted this revision.Nov 21 2024, 17:00
This revision is now accepted and ready to land.Nov 21 2024, 17:00
Closed by commit rABCbc5c8fabb06c: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt (authored by tobias_ruck). · Explain WhyNov 21 2024, 17:10
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCbc5c8fabb06c: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.

Revision Contents
Changeset List

PathSize
src/
config/
6 lines

Diff 51019

View Options

src/config/CMakeLists.txt

Loading...