Page MenuHomePhabricator
Differential D1717

Various nits in walletview.{h|cpp}
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 20:13.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING43df25030112: Various nits in walletview.{h|cpp}
rABC43df25030112: Various nits in walletview.{h|cpp}
Summary

As per title. Braces, Amount construction, etc...

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletwievnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3191
Build 4469: Bitcoin ABC Buildbot (legacy)
Build 4468: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2018, 20:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 20:13
teamcity added a subscriber: teamcity.Sep 4 2018, 20:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 4 2018, 20:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3191: Diff 4757.Sep 4 2018, 20:51
jasonbcox accepted this revision.Sep 4 2018, 21:29
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/walletview.cpp
170

Looks like end needs to be removed in the future since it's not in use.

This revision is now accepted and ready to land.Sep 4 2018, 21:29
Closed by commit rABC43df25030112: Various nits in walletview.{h|cpp} (authored by deadalnix). · Explain WhySep 4 2018, 22:27
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
48 lines
48 lines

Diff 4757

View Options

src/qt/walletview.h

Loading...
View Options

src/qt/walletview.cpp

Loading...