Differential D17186
[cashtab] UI Overhaul Authored by johnkuney on Fri, Nov 22, 16:29.
Details
As discussed here are some proposed UI changes to the app as a whole. It is maybe more changes than the A new desktop layout and color changes are the main updates here, with more granual design improvements to individual pages to come preview the site and check it looks good on mobile and desktop
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log: Run `npm audit` for details. > ecash-lib@0.2.1 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 1s 60 packages are looking for funding run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.1.1 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1483 packages, and audited 3329 packages in 24s 323 packages are looking for funding run `npm fund` for details 4 vulnerabilities (2 moderate, 2 high) To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@2.55.0 build > node scripts/build.js Creating an optimized production build... Treating warnings as errors because process.env.CI = true. Most CI servers set it automatically. Failed to compile. [eslint] src/components/Common/CustomIcons.js Line 139:7: 'Rotate' is assigned a value but never used @typescript-eslint/no-unused-vars src/components/Configure/Configure.js Line 24:10: 'AlertMsg' is defined but never used @typescript-eslint/no-unused-vars Build cashtab-tests failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs: ====== CashTab Unit Tests: <App /> Navigation menu routes to expected components ======
Error: expect(element).toHaveStyle()
- Expected
- max-width: 0;
at Object.toHaveStyle (/work/cashtab/src/components/App/__tests__/App.test.js:262:54)Each failure log is accessible here: Comment Actions another thing to check is npm run extension and extension still has pop-out link in its header
Comment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs: ====== CashTab Unit Tests: <App /> Navigation menu routes to expected components ======
Error: expect(element).toHaveStyle()
- Expected
- max-width: 0;
at Object.toHaveStyle (/work/cashtab/src/components/App/__tests__/App.test.js:269:54)Each failure log is accessible here:
Comment Actions nice! much, much better UI Some ticky-tack stuff. could be handled in separate diffs but imo might as well get it here
 mb search bar is left, tx list is right? or 2 columns for txs if enough width? for the "better flex space" use points...mb better to handle in its own diff, up to you.
Comment Actions
left border missing? also highlight/bg colors of dropdown  Comment Actions  the logo just seems kinda low res could update it in this diff. Up to you on font, appearance...feels like it should change with this overhaul Comment Actions nice lookin great 
agora looks sick on full screen desktop.
Comment Actions nice changes look great. prob ready to land. what about the logo above the menu? assets/cashtab_xec.png? also looks kinda dated. mb we should have an ecash "e" in there as well. say, to the left or right of Cashtab? whatever ... pops, as they say. Prob same for twitter. Comment Actions For sure, what do you think about this one? | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
