Do not use the Amount constructor that take an amount in satoshis in the Qt code
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 20:31.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc390697f690f: Do not use the Amount constructor that take an amount in satoshis in the Qt code
rABCc390697f690f: Do not use the Amount constructor that take an amount in satoshis in the Qt code

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qtamountbuild

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3192
Build 4471: Bitcoin ABC Buildbot (legacy)
Build 4470: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2018, 20:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 20:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3192: Diff 4759.Sep 4 2018, 21:09

deadalnix retitled this revision from Do not use the AMount constructor that take an amount in satoshis in the Qt code to Do not use the Amount constructor that take an amount in satoshis in the Qt code.Sep 5 2018, 12:10

deadalnix added a child revision: D1723: Make the constructor taking satoshi as parameter from the Amount class private.Sep 5 2018, 14:28

jasonbcox accepted this revision.Sep 5 2018, 16:43

This revision is now accepted and ready to land.Sep 5 2018, 16:43

Closed by commit rABCc390697f690f: Do not use the Amount constructor that take an amount in satoshis in the Qt code (authored by deadalnix). · Explain WhySep 5 2018, 18:37

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoinamountfield.cpp

4 lines

bitcoinunits.cpp

2 lines

coincontroldialog.cpp

2 lines

overviewpage.cpp

12 lines

transactiondesc.cpp

2 lines

transactionfilterproxy.cpp

4 lines

transactionrecord.h

8 lines

transactionview.cpp

2 lines

walletmodel.cpp

26 lines

walletmodeltransaction.cpp

24 lines

Diff 4759

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/bitcoinunits.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionfilterproxy.cpp

View Options

src/qt/transactionrecord.h

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/qt/walletmodeltransaction.cpp

Do not use the Amount constructor that take an amount in satoshis in the Qt codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4759

src/qt/bitcoinamountfield.cpp

src/qt/bitcoinunits.cpp

src/qt/coincontroldialog.cpp

src/qt/overviewpage.cpp

src/qt/transactiondesc.cpp

src/qt/transactionfilterproxy.cpp

src/qt/transactionrecord.h

src/qt/transactionview.cpp

src/qt/walletmodel.cpp

src/qt/walletmodeltransaction.cpp

Do not use the Amount constructor that take an amount in satoshis in the Qt code
ClosedPublic
Actions

Revision Contents
Changeset List